post-command: Fix keyless signing. #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The keyless signing feature (used to) rely on the COSIGN_EXPERIMENTAL environment variable being set to "1". The post-command shell script attempts to set this environment variable when executing cosign if the user specifies keyless signing. The environment variable name was missing the underscore character. This caused keyless signing attempts to fail because the shell would interpret "COSIGN" as a shell command. [1] This commit also removes some extra empty space. References 1. https://buildkite.com/metal-toolbox/governor-slack-addon/builds/106#018c122e-21ab-4488-b03a-0c5131595448
gradientsearch
approved these changes
Nov 28, 2023
| @@ -58,15 +58,15 @@ cosign_keyless() { | |||
|
|
|||
| rm out.sig || true | |||
|
|
|||
| COSIGN EXPERIMENTAL=1 cosign sign \ | |||
| COSIGN_EXPERIMENTAL=1 cosign sign \ | |||
There was a problem hiding this comment.
@stephen-fox we do not need the COSIGN_EXPERIMENTAL=1 flag since cosign 2.0 release[1]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The keyless signing feature (used to) rely on the COSIGN_EXPERIMENTAL environment variable being set to "1". The post-command shell script attempts to set this environment variable when executing cosign if the user specifies keyless signing.
The environment variable name was missing the underscore character. This caused keyless signing attempts to fail because the shell would interpret "COSIGN" as a shell command. [1]
This commit also removes some extra empty space.
References